tests/compiler/dart2js/pretty_parameter_test.dart - Issue 11817028: Random fixes discovered when looking through CL 11824035.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/pretty_parameter_test.dart

Issue 11817028: Random fixes discovered when looking through CL 11824035. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: More fixes. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | tests/language/double_to_string_as_exponential2_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/pretty_parameter_test.dart

diff --git a/tests/compiler/dart2js/pretty_parameter_test.dart b/tests/compiler/dart2js/pretty_parameter_test.dart

index 6831370643b6f9ffb30460c83f1f8c5725d49314..6bd0bddcde0364e05fee75c9d2f3637d02d26e84 100644

--- a/tests/compiler/dart2js/pretty_parameter_test.dart

+++ b/tests/compiler/dart2js/pretty_parameter_test.dart

@@ -101,7 +101,7 @@ main() {

regexp = new RegExp(r"a = 2;");

Iterator matches = regexp.allMatches(generated).iterator;

Expect.isTrue(matches.moveNext());

- Expect.isFalse(matches.moveNext);

+ Expect.isFalse(matches.moveNext());

ahe 2013/01/09 20:09:39 Why didn't this turn into a test failure?

floitsch 2013/03/04 15:26:27 Because the test was already marked as failing.

generated = compile(PARAMETER_INIT, entry: 'foo');

regexp = new RegExp("var result = start;");