Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: tests/compiler/dart2js/pretty_parameter_test.dart

Issue 11817028: Random fixes discovered when looking through CL 11824035. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: More fixes. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Test that parameters keep their names in the output. 4 // Test that parameters keep their names in the output.
5 5
6 import 'compiler_helper.dart'; 6 import 'compiler_helper.dart';
7 7
8 const String FOO = r""" 8 const String FOO = r"""
9 void foo(var a, var b) { 9 void foo(var a, var b) {
10 } 10 }
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 regexp = new RegExp("bar === true"); 94 regexp = new RegExp("bar === true");
95 Expect.isTrue(regexp.hasMatch(generated)); 95 Expect.isTrue(regexp.hasMatch(generated));
96 96
97 generated = compile(MULTIPLE_PHIS_ONE_LOCAL, entry: 'foo'); 97 generated = compile(MULTIPLE_PHIS_ONE_LOCAL, entry: 'foo');
98 regexp = new RegExp(r"var a = 2;"); 98 regexp = new RegExp(r"var a = 2;");
99 Expect.isTrue(regexp.hasMatch(generated)); 99 Expect.isTrue(regexp.hasMatch(generated));
100 100
101 regexp = new RegExp(r"a = 2;"); 101 regexp = new RegExp(r"a = 2;");
102 Iterator matches = regexp.allMatches(generated).iterator; 102 Iterator matches = regexp.allMatches(generated).iterator;
103 Expect.isTrue(matches.moveNext()); 103 Expect.isTrue(matches.moveNext());
104 Expect.isFalse(matches.moveNext); 104 Expect.isFalse(matches.moveNext());
ahe 2013/01/09 20:09:39 Why didn't this turn into a test failure?
floitsch 2013/03/04 15:26:27 Because the test was already marked as failing.
105 105
106 generated = compile(PARAMETER_INIT, entry: 'foo'); 106 generated = compile(PARAMETER_INIT, entry: 'foo');
107 regexp = new RegExp("var result = start;"); 107 regexp = new RegExp("var result = start;");
108 Expect.isTrue(regexp.hasMatch(generated)); 108 Expect.isTrue(regexp.hasMatch(generated));
109 } 109 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | tests/language/double_to_string_as_exponential2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698