Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: src/codegen.h

Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comment response Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/codegen.h
diff --git a/src/codegen.h b/src/codegen.h
index 0ac68c2eac7c52bf493b93de0c0bac4e722f6378..8ec0dfdbf272ef9d03ac9f891498b28e68a04dc4 100644
--- a/src/codegen.h
+++ b/src/codegen.h
@@ -96,9 +96,14 @@ UnaryMathFunction CreateSqrtFunction();
class ElementsTransitionGenerator : public AllStatic {
public:
- static void GenerateMapChangeElementsTransition(MacroAssembler* masm);
- static void GenerateSmiToDouble(MacroAssembler* masm, Label* fail);
- static void GenerateDoubleToObject(MacroAssembler* masm, Label* fail);
+ // if |mode| is set to DONT_TRACK_ALLOCATION_SITE,
Toon Verwaest 2013/01/16 13:35:55 Uppercase I of If.
mvstanton 2013/01/16 14:21:00 Done.
+ // |allocation_site_info_found| may be NULL.
+ static void GenerateMapChangeElementsTransition(MacroAssembler* masm,
Toon Verwaest 2013/01/16 13:35:55 In function declarations, put the arguments right
mvstanton 2013/01/16 14:21:00 Done, and updated the two functions below to have
+ AllocationSiteMode mode, Label* allocation_site_info_found);
+ static void GenerateSmiToDouble(MacroAssembler* masm,
+ AllocationSiteMode mode, Label* fail);
+ static void GenerateDoubleToObject(MacroAssembler* masm,
+ AllocationSiteMode mode, Label* fail);
private:
DISALLOW_COPY_AND_ASSIGN(ElementsTransitionGenerator);

Powered by Google App Engine
This is Rietveld 408576698