Additional work to get array literal allocation tracking working, even with --always-opt

src/codegen.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 78 matching lines @@
 // generated code both in runtime and compiled code.
 typedef double (*UnaryMathFunction)(double x);
 
 UnaryMathFunction CreateTranscendentalFunction(TranscendentalCache::Type type);
 UnaryMathFunction CreateExpFunction();
 UnaryMathFunction CreateSqrtFunction();
 
 
 class ElementsTransitionGenerator : public AllStatic {
  public:
-  static void GenerateMapChangeElementsTransition(MacroAssembler* masm);
-  static void GenerateSmiToDouble(MacroAssembler* masm, Label* fail);
-  static void GenerateDoubleToObject(MacroAssembler* masm, Label* fail);
+  // if |mode| is set to DONT_TRACK_ALLOCATION_SITE,

[Toon Verwaest, 2013/01/16 13:35:55]

Uppercase I of If.

[mvstanton, 2013/01/16 14:21:00]

Done.

+  // |allocation_site_info_found| may be NULL.
+  static void GenerateMapChangeElementsTransition(MacroAssembler* masm,

[Toon Verwaest, 2013/01/16 13:35:55]

In function declarations, put the arguments right below each other:

static void GenerateMap...(MacroAssembler* masm,
                           AllocationSiteMode mode,
                           Label* allocation_site_info_found);

[mvstanton, 2013/01/16 14:21:00]

Done, and updated the two functions below to have the same style. However, I
have to indent the lines of the GenerateMapChangeElementsTransition arguments
because they are too long for the 80 column character limit.

+      AllocationSiteMode mode, Label* allocation_site_info_found);
+  static void GenerateSmiToDouble(MacroAssembler* masm,
+                                  AllocationSiteMode mode, Label* fail);
+  static void GenerateDoubleToObject(MacroAssembler* masm,
+                                     AllocationSiteMode mode, Label* fail);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ElementsTransitionGenerator);
 };
 
 
 class SeqStringSetCharGenerator : public AllStatic {
  public:
   static void Generate(MacroAssembler* masm,
                        String::Encoding encoding,
                        Register string,
                        Register index,
                        Register value);
  private:
   DISALLOW_COPY_AND_ASSIGN(SeqStringSetCharGenerator);
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_CODEGEN_H_