Issue 1181533003: Support for alignItems (test incoming)

Issue 1181533003: Support for alignItems (test incoming) (Closed)

Created:
5 years, 6 months ago by jackson

Modified:
5 years, 6 months ago

Reviewers:
hansmuller, abarth-chromium, Hixie

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Support for alignItems (test incoming) R=abarth@chromium.org, abarth, hansmuller Committed: https://chromium.googlesource.com/external/mojo/+/bd2b33b8393e481472a9d97798e2b60d2f6515c8

Patch Set 1 #

Total comments: 2

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -12 lines)			Patch
M	sky/sdk/lib/framework/components2/tool_bar.dart	View	1 chunk	+4 lines, -8 lines	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View	2 chunks	+4 lines, -1 line	2 comments	Download
M	sky/sdk/lib/framework/rendering/flex.dart	View	5 chunks	+31 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jackson

Committed patchset #1 (id:1) manually as bd2b33b8393e481472a9d97798e2b60d2f6515c8 (presubmit successful).

5 years, 6 months ago (2015-06-10 23:35:54 UTC) #3

Hixie

https://codereview.chromium.org/1181533003/diff/1/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (right): https://codereview.chromium.org/1181533003/diff/1/sky/sdk/lib/framework/fn2.dart#newcode791 sky/sdk/lib/framework/fn2.dart:791: this.alignItems: FlexAlignItems.center don't specify arguments when the value you're ...

5 years, 6 months ago (2015-06-10 23:40:13 UTC) #5

jackson

5 years, 6 months ago (2015-06-11 16:58:38 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/1181533003/diff/1/sky/sdk/lib/framework/fn2.dart
File sky/sdk/lib/framework/fn2.dart (right):

https://codereview.chromium.org/1181533003/diff/1/sky/sdk/lib/framework/fn2.d...
sky/sdk/lib/framework/fn2.dart:791: this.alignItems: FlexAlignItems.center
On 2015/06/10 23:40:13, Hixie wrote:
> don't specify arguments when the value you're setting is the default value

we discussed this and it sounds like we're on the same page now

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages