Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: sky/sdk/lib/framework/components2/tool_bar.dart

Issue 1181533003: Support for alignItems (test incoming) (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/sdk/lib/framework/fn2.dart » ('j') | sky/sdk/lib/framework/fn2.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/components2/tool_bar.dart
diff --git a/sky/sdk/lib/framework/components2/tool_bar.dart b/sky/sdk/lib/framework/components2/tool_bar.dart
index ea5dec223a4b0118c12813ce78f6b343776f5360..a4df2eb8a32c7bcde727e6fc44740c6343e82b57 100644
--- a/sky/sdk/lib/framework/components2/tool_bar.dart
+++ b/sky/sdk/lib/framework/components2/tool_bar.dart
@@ -35,15 +35,11 @@ class ToolBar extends Component {
if (right != null)
children.addAll(right);
- // TODO(hansmuller): use align-items:flex-end when Flex supports it.
- UINode bottomJustifiedChild = new Flex([
- new Container(child: new Flex(children), height: kToolBarHeight)
- ],
- direction: FlexDirection.vertical,
- justifyContent: FlexJustifyContent.flexEnd);
-
return new Container(
- child: bottomJustifiedChild,
+ child: new Flex(
+ [new Container(child: new Flex(children), height: kToolBarHeight)],
+ alignItems: FlexAlignItems.flexEnd
+ ),
padding: new EdgeDims.symmetric(horizontal: 8.0),
decoration: new BoxDecoration(
backgroundColor: backgroundColor,
« no previous file with comments | « no previous file | sky/sdk/lib/framework/fn2.dart » ('j') | sky/sdk/lib/framework/fn2.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698