Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1181523002: Fix analyzer warnings (and probably also bugs) in flex.dart (Closed)

Created:
5 years, 6 months ago by jackson
Modified:
5 years, 6 months ago
Reviewers:
Hixie, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix analyzer warnings (and probably also bugs) in flex.dart R=abarth@chromium.org, hixie Committed: https://chromium.googlesource.com/external/mojo/+/7a97a53869de88e096833a42ad2d19e4d604cde0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M sky/sdk/lib/framework/rendering/flex.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-10 22:33:57 UTC) #2
jackson
Committed patchset #1 (id:1) manually as 7a97a53869de88e096833a42ad2d19e4d604cde0 (presubmit successful).
5 years, 6 months ago (2015-06-10 22:36:16 UTC) #3
Hixie
5 years, 6 months ago (2015-06-10 22:36:16 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698