Fix analyzer warnings (and probably also bugs) in flex.dart

sky/sdk/lib/framework/rendering/flex.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 import 'dart:math' as math;
 import 'box.dart';
 import 'object.dart';
 
 class FlexBoxParentData extends BoxParentData with ContainerParentDataMixin<RenderBox> {
   int flex;
@@ skipping 100 matching lines @@
       // main direction and use those constraints to determine their max
       // intrinsic size in the cross direction. We don't care if the caller
       // asked for max or min -- the answer is always computed using the
       // max size in the main direction.
 
       double availableMainSpace;
       BoxConstraints childConstraints;
       switch(_direction) {
         case FlexDirection.horizontal:
           childConstraints = new BoxConstraints(maxWidth: constraints.maxWidth);
-          availableMainSpace = innerConstraints.maxWidth;
+          availableMainSpace = constraints.maxWidth;
           break;
         case FlexDirection.vertical:
           childConstraints = new BoxConstraints(maxHeight: constraints.maxHeight);
-          availableMainSpace = innerConstraints.maxHeight;
+          availableMainSpace = constraints.maxHeight;
           break;
       }
 
       // Get inflexible space using the max in the main direction
       int totalFlex = 0;
       double inflexibleSpace = 0.0;
       double maxCrossSize = 0.0;
       RenderBox child = firstChild;
       while (child != null) {
         int flex = _getFlex(child);
@@ skipping 44 matching lines @@
               break;
           }
           maxCrossSize = math.max(maxCrossSize, crossSize);
         }
         child = child.parentData.nextSibling;
       }
 
       // Ensure that we don't violate the given constraints with our result
       switch(_direction) {
         case FlexDirection.horizontal:
-          return innerConstraints.constrainHeight(maxCrossSize);
+          return constraints.constrainHeight(maxCrossSize);
         case FlexDirection.vertical:
-          return innerConstraints.constrainWidth(maxCrossSize);
+          return constraints.constrainWidth(maxCrossSize);
       }
     }
   }
 
   double getMinIntrinsicWidth(BoxConstraints constraints) {
     return _getIntrinsicSize(
       constraints: constraints,
       sizingDirection: FlexDirection.horizontal,
       childSize: (c, innerConstraints) => c.getMinIntrinsicWidth(innerConstraints)
     );
@@ skipping 146 matching lines @@
   }
 
   void hitTestChildren(HitTestResult result, { Point position }) {
     defaultHitTestChildren(result, position: position);
   }
 
   void paint(RenderObjectDisplayList canvas) {
     defaultPaint(canvas);
   }
 }