Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: Source/core/events/PromiseRejectionEvent.h

Issue 1181353005: Return null when no promise/reason is given in PromiseRejectionEvent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/events/PromiseRejectionEvent.h
diff --git a/Source/core/events/PromiseRejectionEvent.h b/Source/core/events/PromiseRejectionEvent.h
index 40d347f445fc666d27c88102a09e1c3c918a55ab..63784198e73ccd689afcd066abc10c4cefc71c2f 100644
--- a/Source/core/events/PromiseRejectionEvent.h
+++ b/Source/core/events/PromiseRejectionEvent.h
@@ -6,8 +6,6 @@
#define PromiseRejectionEvent_h
#include "bindings/core/v8/ScopedPersistent.h"
-#include "bindings/core/v8/ScriptPromise.h"
-#include "bindings/core/v8/ScriptValue.h"
#include "core/CoreExport.h"
#include "core/events/Event.h"
#include "core/events/PromiseRejectionEventInit.h"
@@ -26,8 +24,8 @@ public:
return adoptRefWillBeNoop(new PromiseRejectionEvent(type, initializer));
}
- ScriptValue reason(ScriptState*) const;
- ScriptPromise promise(ScriptState*) const;
+ v8::Local<v8::Value> reason(v8::Isolate*) const;
+ v8::Local<v8::Value> promise(v8::Isolate*) const;
haraken 2015/06/18 17:52:09 Can we keep returning ScriptValue and ScriptPromis
virtual const AtomicString& interfaceName() const override;

Powered by Google App Engine
This is Rietveld 408576698