Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: Source/core/events/PromiseRejectionEvent.cpp

Issue 1181353005: Return null when no promise/reason is given in PromiseRejectionEvent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/events/PromiseRejectionEvent.cpp
diff --git a/Source/core/events/PromiseRejectionEvent.cpp b/Source/core/events/PromiseRejectionEvent.cpp
index 2a4eb14da3e3e3f7db1e1889e116c6543a59e2ba..6351986ce8cbc1144df988d415b6d1230a48137a 100644
--- a/Source/core/events/PromiseRejectionEvent.cpp
+++ b/Source/core/events/PromiseRejectionEvent.cpp
@@ -29,16 +29,14 @@ PromiseRejectionEvent::~PromiseRejectionEvent()
{
}
-ScriptPromise PromiseRejectionEvent::promise(ScriptState* state) const
+v8::Local<v8::Value> PromiseRejectionEvent::promise(v8::Isolate* isolate) const
{
- v8::Local<v8::Value> value = m_promise.newLocal(state->isolate());
- return ScriptPromise(state, value);
+ return m_promise.newLocal(isolate);
}
-ScriptValue PromiseRejectionEvent::reason(ScriptState* state) const
+v8::Local<v8::Value> PromiseRejectionEvent::reason(v8::Isolate* isolate) const
{
- v8::Local<v8::Value> value = m_reason.newLocal(state->isolate());
- return ScriptValue(state, value);
+ return m_reason.newLocal(isolate);
}
const AtomicString& PromiseRejectionEvent::interfaceName() const

Powered by Google App Engine
This is Rietveld 408576698