chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java - Issue 1181353002: Disable custom tabs if the feature is disabled in finch experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

Issue 1181353002: Disable custom tabs if the feature is disabled in finch experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Final comments addressed Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

index 12ed7eea9b5a9129e299ac3122e685f50439e902..1a64f3a5289a3b8529c43c9a4b3662cb650ba650 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

@@ -8,6 +8,8 @@ import android.app.Service;

import android.content.Intent;

import android.os.IBinder;

+import org.chromium.chrome.browser.preferences.ChromePreferenceManager;

/**

* Custom tabs connection service, used by the embedded Chrome activities.

@@ -19,6 +21,8 @@ public class CustomTabsConnectionService extends Service {

@Override

public IBinder onBind(Intent intent) {

+ if (!ChromePreferenceManager.getInstance(this).getCustomTabsEnabled()) return null;

return (IBinder) CustomTabsConnection.getInstance(getApplication());

}