chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java - Issue 1181353002: Disable custom tabs if the feature is disabled in finch experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Issue 1181353002: Disable custom tabs if the feature is disabled in finch experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Final comments addressed Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/DeferredStartupHandler.java ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

index ada0123db740fad2e112eb338aa72c88f0a1d05a..c898f2b67f2ba37c2d6c33cf79231204120a4b1e 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

@@ -28,6 +28,7 @@ import android.util.LongSparseArray;

import android.util.SparseArray;

import android.view.WindowManager;

+import org.chromium.base.FieldTrialList;

import org.chromium.base.Log;

import org.chromium.base.ThreadUtils;

import org.chromium.base.VisibleForTesting;

@@ -481,6 +482,7 @@ class CustomTabsConnection extends ICustomTabsConnectionService.Stub {

}

private boolean mayPrerender() {

+ if (FieldTrialList.findFullName("CustomTabs").equals("DisablePrerender")) return false;

ConnectivityManager cm =

(ConnectivityManager) mApplication.getApplicationContext().getSystemService(

Context.CONNECTIVITY_SERVICE);