chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h - Issue 1181263007: WebView context menu cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

Issue 1181263007: WebView context menu cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Rebased. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/menu_manager.h ('K') | « chrome/browser/extensions/menu_manager.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc » ('j') | chrome/browser/renderer_context_menu/render_view_context_menu.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

index d46756959e7041ae84d7864b9a1d18d4365ba41b..8ecc56d8e3041b768b7a472189e28affcfc092aa 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

@@ -29,7 +29,7 @@ class ChromeWebViewGuestDelegate : public WebViewGuestDelegate {

// WebViewGuestDelegate implementation.

bool HandleContextMenu(const content::ContextMenuParams& params) override;

void OnDidInitialize() override;

- void OnGuestDestroyed() override;

+ void OnGuestDestroyed() override {}

Fady Samuel 2015/06/19 18:03:12 Please get rid of this entirely from delegates if

Devlin 2015/06/19 18:05:48 +1.

paulmeyer 2015/06/19 18:18:10 Done.

void OnShowContextMenu(int request_id, const MenuItemVector* items) override;

WebViewGuest* web_view_guest() const { return web_view_guest_; }

@@ -80,4 +80,3 @@ class ChromeWebViewGuestDelegate : public WebViewGuestDelegate {

} // namespace extensions

#endif // CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_CHROME_WEB_VIEW_GUEST_DELEGATE_H_