chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc - Issue 1181263007: WebView context menu cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

Issue 1181263007: WebView context menu cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Rebased. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h ('K') | « chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h ('k') | chrome/browser/renderer_context_menu/render_view_context_menu.cc » ('j') | chrome/browser/renderer_context_menu/render_view_context_menu.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

index ad34b5c77c9ffd69d472c9dca76c9ca1e2a0aca7..0a1dda0f6e985e6f269c473a4fb31ec4651f61d4 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

@@ -69,15 +69,6 @@ void ChromeWebViewGuestDelegate::OnDidInitialize() {

#endif

}

-void ChromeWebViewGuestDelegate::OnGuestDestroyed() {

- // Clean up custom context menu items for this guest.

- MenuManager* menu_manager = MenuManager::Get(

- Profile::FromBrowserContext(web_view_guest()->browser_context()));

- menu_manager->RemoveAllContextItems(MenuItem::ExtensionKey(

- web_view_guest()->owner_host(),

- web_view_guest()->view_instance_id()));

// static

scoped_ptr<base::ListValue> ChromeWebViewGuestDelegate::MenuModelToValue(

const ui::SimpleMenuModel& menu_model) {