WebView context menu cleanup.

extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

Index: extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
diff --git a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc b/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
index 89d25ed31fe237e25df37cb2bf5c09934b8b182b..9e511e6ac93b94777708526358a4f28db7476f59 100644
--- a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
+++ b/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
@@ -730,6 +730,30 @@ bool WebViewInternalReloadFunction::RunAsyncSafe(WebViewGuest* guest) {
   return true;
 }
 
+WebViewInternalReportExtensionIdFunction::
+    WebViewInternalReportExtensionIdFunction() {
+}
+
+WebViewInternalReportExtensionIdFunction::
+    ~WebViewInternalReportExtensionIdFunction() {
+}
+
+bool WebViewInternalReportExtensionIdFunction::RunAsync() {
+  scoped_ptr<web_view_internal::ReportExtensionId::Params> params(
+      web_view_internal::ReportExtensionId::Params::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+
+  // Some WebViews are not in extensions. This is not an error, so |true| is
+  // still returned.
+  if (!extension())
+    return true;
+
+  WebViewGuest::RegisterExtensionID(extension_id(),

[Devlin, 2015/07/06 17:46:18]

This is a pretty bad hack.  This is basically hoping that the extension id is
set correctly on the renderer side, and then using that getting forwarded to the
browser.  The renderer side, in turn, actually just uses the url of the frame
that sent the message.  Relying on this massive chain to get to here strikes me
as fragile, and, frankly, rather slow.  If we want to rely on URL for the
extension id (which is actually okay, for the most part - we do it in a lot of
places), surely a web view knows its own url, without having to do round-trips
to/from the renderer?

+                                    render_frame_host()->GetProcess()->GetID(),
+                                    params->view_instance_id);
+  return true;
+}
+
 WebViewInternalSetPermissionFunction::WebViewInternalSetPermissionFunction() {
 }