WebView context menu cleanup.

extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/guest_view/web_view/web_view_internal_api.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/public/browser/browser_context.h"
@@ skipping 712 matching lines @@
 }
 
 WebViewInternalReloadFunction::~WebViewInternalReloadFunction() {
 }
 
 bool WebViewInternalReloadFunction::RunAsyncSafe(WebViewGuest* guest) {
   guest->Reload();
   return true;
 }
 
+WebViewInternalReportExtensionIdFunction::
+    WebViewInternalReportExtensionIdFunction() {
+}
+
+WebViewInternalReportExtensionIdFunction::
+    ~WebViewInternalReportExtensionIdFunction() {
+}
+
+bool WebViewInternalReportExtensionIdFunction::RunAsync() {
+  scoped_ptr<web_view_internal::ReportExtensionId::Params> params(
+      web_view_internal::ReportExtensionId::Params::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+
+  // Some WebViews are not in extensions. This is not an error, so |true| is
+  // still returned.
+  if (!extension())
+    return true;
+
+  WebViewGuest::RegisterExtensionID(extension_id(),

[Devlin, 2015/07/06 17:46:18]

This is a pretty bad hack.  This is basically hoping that the extension id is
set correctly on the renderer side, and then using that getting forwarded to the
browser.  The renderer side, in turn, actually just uses the url of the frame
that sent the message.  Relying on this massive chain to get to here strikes me
as fragile, and, frankly, rather slow.  If we want to rely on URL for the
extension id (which is actually okay, for the most part - we do it in a lot of
places), surely a web view knows its own url, without having to do round-trips
to/from the renderer?

+                                    render_frame_host()->GetProcess()->GetID(),
+                                    params->view_instance_id);
+  return true;
+}
+
 WebViewInternalSetPermissionFunction::WebViewInternalSetPermissionFunction() {
 }
 
 WebViewInternalSetPermissionFunction::~WebViewInternalSetPermissionFunction() {
 }
 
 bool WebViewInternalSetPermissionFunction::RunAsyncSafe(WebViewGuest* guest) {
   scoped_ptr<web_view_internal::SetPermission::Params> params(
       web_view_internal::SetPermission::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
@@ skipping 149 matching lines @@
   // Will finish asynchronously.
   return true;
 }
 
 void WebViewInternalClearDataFunction::ClearDataDone() {
   Release();  // Balanced in RunAsync().
   SendResponse(true);
 }
 
 }  // namespace extensions