Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2052)

Unified Diff: content/public/browser/background_tracing_manager.h

Issue 1181213002: Slow Reports - Embed Metadata in Traces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | content/public/browser/trace_uploader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/background_tracing_manager.h
diff --git a/content/public/browser/background_tracing_manager.h b/content/public/browser/background_tracing_manager.h
index 75e2d340cd8d46bb96dda3ced749ee7ef25e0acb..3454d06279424deaebd896a61741e8bec603cafb 100644
--- a/content/public/browser/background_tracing_manager.h
+++ b/content/public/browser/background_tracing_manager.h
@@ -23,13 +23,15 @@ class BackgroundTracingManager {
// ReceiveCallback will will be called on the UI thread every time the
// BackgroundTracingManager finalizes a trace. The first parameter of
- // this callback is the trace data. The second is a callback to
+ // this callback is the trace data. The second is metadata that was
+ // generated and embedded into the trace. The third is a callback to
// notify the BackgroundTracingManager that you've finished processing
// the trace data.
//
// Example:
//
- // void Upload(const base::RefCountedString* data,
+ // void Upload(const scoped_refptr<base::RefCountedString>& data,
+ // scoped_ptr<base::DictionaryValue>,
// base::Closure done_callback) {
// BrowserThread::PostTaskAndReply(
// BrowserThread::FILE,
@@ -40,6 +42,7 @@ class BackgroundTracingManager {
// }
//
typedef base::Callback<void(const scoped_refptr<base::RefCountedString>&,
+ scoped_ptr<base::DictionaryValue>,
base::Closure)> ReceiveCallback;
// Set the triggering rules for when to start recording.
« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | content/public/browser/trace_uploader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698