content/browser/tracing/tracing_ui.cc - Issue 1181213002: Slow Reports - Embed Metadata in Traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_ui.cc

Issue 1181213002: Slow Reports - Embed Metadata in Traces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/tracing/tracing_ui.cc

diff --git a/content/browser/tracing/tracing_ui.cc b/content/browser/tracing/tracing_ui.cc

index 8328330f4457d36cab08c42983437b4f6b1ed11e..ebcad3d772cf453864cac85ced3d9fa57e62f289 100644

--- a/content/browser/tracing/tracing_ui.cc

+++ b/content/browser/tracing/tracing_ui.cc

@@ -327,7 +327,8 @@ void TracingUI::DoUpload(const base::ListValue* args) {

trace_uploader_ = delegate_->GetTraceUploader(

web_ui()->GetWebContents()->GetBrowserContext()->GetRequestContext());

DCHECK(trace_uploader_);

- trace_uploader_->DoUpload(file_contents, progress_callback, done_callback);

+ trace_uploader_->DoUpload(file_contents, nullptr, progress_callback,

+ done_callback);

// TODO(mmandlis): Add support for stopping the upload in progress.

}