Source/bindings/scripts/v8_methods.py - Issue 1181113006: bindings: Introduces on_{instance,prototype,interface} in the code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 1181113006: bindings: Introduces on_{instance,prototype,interface} in the code generator. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed review comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index bf56ab3748212e3dbcb8affeea8f0a60317e0847..0f2ef27896e6cb71e99f474d46404769b01aa5c1 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -188,6 +188,9 @@ def method_context(interface, method, is_visible=True):

'number_of_required_or_variadic_arguments': len([

argument for argument in arguments

if not argument.is_optional]),

+ 'on_instance': v8_utilities.on_instance(interface, method),

+ 'on_interface': v8_utilities.on_interface(interface, method),

+ 'on_prototype': v8_utilities.on_prototype(interface, method),

'only_exposed_to_private_script': is_only_exposed_to_private_script,

'private_script_v8_value_to_local_cpp_value': idl_type.v8_value_to_local_cpp_value(

extended_attributes, 'v8Value', 'cppValue', isolate='scriptState->isolate()', bailout_return_value='false'),

« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »