Source/bindings/scripts/v8_attributes.py - Issue 1181113006: bindings: Introduces on_{instance,prototype,interface} in the code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 1181113006: bindings: Introduces on_{instance,prototype,interface} in the code generator. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed review comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index d2cf8cd8389daa058c113ce54729dcdbe1ac608e..4980307e80e1956d842690cb081b4b05bcd443da 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -138,6 +138,9 @@ def attribute_context(interface, attribute):

'is_static': attribute.is_static,

'is_url': 'URL' in extended_attributes,

'is_unforgeable': is_unforgeable(interface, attribute),

+ 'on_instance': v8_utilities.on_instance(interface, attribute),

+ 'on_interface': v8_utilities.on_interface(interface, attribute),

+ 'on_prototype': v8_utilities.on_prototype(interface, attribute),

'use_output_parameter_for_result': idl_type.use_output_parameter_for_result,

'measure_as': v8_utilities.measure_as(attribute, interface), # [MeasureAs]

'name': attribute.name,

« no previous file with comments | « Source/bindings/core/v8/V8DOMConfiguration.cpp ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »