Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1181013007: Debugger: require debugger to be active when dealing with breaks. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: require debugger to be active when dealing with breaks. This invariant will save us some head ache. The changes to test-debug/DebugStub is due to the fact that it abuses the ability to set break points in code that has no debug break slots. This is now no longer possible. R=ulan@chromium.org BUG=v8:4132 LOG=N Committed: https://crrev.com/75350f1ef0ebf189ef3583183eae694a25597fc0 Cr-Commit-Position: refs/heads/master@{#29038}

Patch Set 1 #

Patch Set 2 : fix yet another test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -59 lines) Patch
M src/debug.h View 2 chunks +4 lines, -12 lines 0 comments Download
M src/debug.cc View 3 chunks +23 lines, -3 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 8 chunks +9 lines, -1 line 0 comments Download
M test/cctest/cctest.h View 1 chunk +12 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 13 chunks +24 lines, -30 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/debug-liveedit-breakpoints.js View 2 chunks +2 lines, -0 lines 0 comments Download
M test/mjsunit/debug-liveedit-patch-positions.js View 2 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/debug-liveedit-stack-padding.js View 3 chunks +3 lines, -1 line 0 comments Download
M test/mjsunit/debug-script.js View 2 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/debug-script-breakpoints.js View 2 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/debug-stepin-positions.js View 3 chunks +7 lines, -4 lines 0 comments Download
M test/mjsunit/deserialize-script-id.js View 2 chunks +5 lines, -0 lines 0 comments Download
M test/mjsunit/es6/debug-evaluate-blockscopes.js View 3 chunks +6 lines, -2 lines 0 comments Download
M test/mjsunit/es6/generators-relocation.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-1586.js View 2 chunks +4 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-2318.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-424142.js View 2 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-474297.js View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-debug-code-recompilation.js View 2 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-prepare-break-while-recompile.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
5 years, 6 months ago (2015-06-12 11:39:58 UTC) #1
ulan
lgtm
5 years, 6 months ago (2015-06-15 10:41:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181013007/1
5 years, 6 months ago (2015-06-15 12:00:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/3602)
5 years, 6 months ago (2015-06-15 12:24:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181013007/20001
5 years, 6 months ago (2015-06-16 06:37:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 07:11:17 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 07:11:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75350f1ef0ebf189ef3583183eae694a25597fc0
Cr-Commit-Position: refs/heads/master@{#29038}

Powered by Google App Engine
This is Rietveld 408576698