Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/debug.h

Issue 1181013007: Debugger: require debugger to be active when dealing with breaks. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix yet another test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.h
diff --git a/src/debug.h b/src/debug.h
index 6a267a8e8cbe0e1cbb5cc05411d4765a271ab443..82d37bb1d1af04ec5d5f2882cfeb4069912cf812 100644
--- a/src/debug.h
+++ b/src/debug.h
@@ -129,17 +129,8 @@ class BreakLocation {
private:
BreakLocation(Handle<DebugInfo> debug_info, RelocInfo* rinfo,
- RelocInfo* original_rinfo, int position, int statement_position)
- : debug_info_(debug_info),
- pc_offset_(static_cast<int>(rinfo->pc() - debug_info->code()->entry())),
- original_pc_offset_(static_cast<int>(
- original_rinfo->pc() - debug_info->original_code()->entry())),
- rmode_(rinfo->rmode()),
- original_rmode_(original_rinfo->rmode()),
- data_(rinfo->data()),
- original_data_(original_rinfo->data()),
- position_(position),
- statement_position_(statement_position) {}
+ RelocInfo* original_rinfo, int position,
+ int statement_position);
class Iterator {
public:
@@ -526,7 +517,8 @@ class Debug {
static void RecordEvalCaller(Handle<Script> script);
bool CheckExecutionState(int id) {
- return !debug_context().is_null() && break_id() != 0 && break_id() == id;
+ return is_active() && !debug_context().is_null() && break_id() != 0 &&
+ break_id() == id;
}
// Flags and states.
« no previous file with comments | « no previous file | src/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698