[strong] Make strong 'this' optional for experimentation

[strong] Make strong 'this' optional for experimentation

R=arv@chromium.org, conradw@chromium.org
BUG=v8:3956
LOG=N

Committed: https://crrev.com/982b46aeb79e2fb8008040f98b6ae3437a1ef5ce
Cr-Commit-Position: refs/heads/master@{#29026}

[conradw, 2015-06-12 15:01:34]

https://codereview.chromium.org/1180943007/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1180943007/diff/1/src/parser.cc#newcode2566
src/parser.cc:2566: if ((FLAG_strong_this || peek() != Token::THIS) &&
Could the peek() check be eliminated by shifting the flag check to if
(!FLAG_strong_this) { break; } in the THIS case with a fallthrough?

[conradw, 2015-06-12 15:04:58]

https://codereview.chromium.org/1180943007/diff/1/src/preparser.cc
File src/preparser.cc (right):

https://codereview.chromium.org/1180943007/diff/1/src/preparser.cc#newcode603
src/preparser.cc:603: if ((FLAG_strong_this || peek() != Token::THIS) &&
Similar here (sorry for spam)

[rossberg, 2015-06-15 08:50:30]

https://codereview.chromium.org/1180943007/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1180943007/diff/1/src/parser.cc#newcode2566
src/parser.cc:2566: if ((FLAG_strong_this || peek() != Token::THIS) &&
On 2015/06/12 15:01:34, conradw wrote:
> Could the peek() check be eliminated by shifting the flag check to if
> (!FLAG_strong_this) { break; } in the THIS case with a fallthrough?

Done.

https://codereview.chromium.org/1180943007/diff/1/src/preparser.cc
File src/preparser.cc (right):

https://codereview.chromium.org/1180943007/diff/1/src/preparser.cc#newcode603
src/preparser.cc:603: if ((FLAG_strong_this || peek() != Token::THIS) &&
On 2015/06/12 15:04:58, conradw wrote:
> Similar here (sorry for spam)

Done.

[conradw, 2015-06-15 10:57:24]

LGTM (not that this does anything :P)

[Dmitry Lomov (no reviews), 2015-06-15 11:52:52]

dslomov@chromium.org changed reviewers:
+ dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-06-15 11:52:53]

lgtm

https://codereview.chromium.org/1180943007/diff/20001/src/preparser.cc
File src/preparser.cc (right):

https://codereview.chromium.org/1180943007/diff/20001/src/preparser.cc#newcod...
src/preparser.cc:602: if (!FLAG_strong_this) break;
Please add: 
 // Fall through.

[rossberg, 2015-06-15 11:58:04]

The CQ bit was checked by rossberg@chromium.org

[rossberg, 2015-06-15 11:58:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
conradw@chromium.org, dslomov@chromium.org
Link to the patchset: https://codereview.chromium.org/1180943007/#ps40001
(title: "Comments")

[commit-bot: I haz the power, 2015-06-15 11:58:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180943007/40001

[commit-bot: I haz the power, 2015-06-15 12:22:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-15 12:22:56]

Patchset 3 (id:??) landed as
https://crrev.com/982b46aeb79e2fb8008040f98b6ae3437a1ef5ce
Cr-Commit-Position: refs/heads/master@{#29026}

[arv (Not doing code reviews), 2015-06-16 17:20:12]

No tests?