src/preparser.h - Issue 1180943007: [strong] Make strong 'this' optional for experimentation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.h

Issue 1180943007: [strong] Make strong 'this' optional for experimentation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/preparser.h

diff --git a/src/preparser.h b/src/preparser.h

index dd36de789090d35e8724e71fce2b4f7605acd5a8..fe31564daf71242c3197a41d30dc758d2622febf 100644

--- a/src/preparser.h

+++ b/src/preparser.h

@@ -2064,7 +2064,7 @@ ParserBase<Traits>::ParsePrimaryExpression(ExpressionClassifier* classifier,

case Token::THIS: {

BindingPatternUnexpectedToken(classifier);

Consume(Token::THIS);

- if (is_strong(language_mode())) {

+ if (FLAG_strong_this && is_strong(language_mode())) {

// Constructors' usages of 'this' in strong mode are parsed separately.

// TODO(rossberg): this does not work with arrow functions yet.

if (i::IsConstructor(function_state_->kind())) {

« no previous file with comments | « src/parser.cc ('k') | src/preparser.cc » ('j') | no next file with comments »