Issue 1180943002: Reland of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where re…

Issue 1180943002: Reland of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where re… (Closed)

Created:
5 years, 6 months ago by Toon Verwaest

Modified:
5 years, 6 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev, Yang

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Reland of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/) BUG=v8:4137 LOG=n Committed: https://crrev.com/a066202b17f5f53cb3419e7dd9785e9f7ce36f97 Cr-Commit-Position: refs/heads/master@{#29000}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+189 lines, -302 lines)			Patch
M	src/api.cc	View	5 chunks	+39 lines, -15 lines	0 comments	Download
M	src/api-natives.cc	View	1 chunk	+11 lines, -19 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/ic/ic.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/json-parser.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/lookup.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	src/lookup.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/objects.h	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	src/objects.cc	View	5 chunks	+6 lines, -16 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/runtime/runtime.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/runtime/runtime-classes.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	src/runtime/runtime-debug.cc	View	17 chunks	+61 lines, -97 lines	0 comments	Download
M	src/runtime/runtime-object.cc	View	4 chunks	+27 lines, -109 lines	0 comments	Download
M	src/scopeinfo.cc	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180943002/1

5 years, 6 months ago (2015-06-12 12:12:33 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-12 12:39:57 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a066202b17f5f53cb3419e7dd9785e9f7ce36f97
Cr-Commit-Position: refs/heads/master@{#29000}