Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: LayoutTests/inspector-protocol/page/javascriptDialogEvents.html

Issue 1180843006: [DevTools] Add dialog type and return value to Page.javascriptDialog{Opening,Closed}. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: frontend Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector-protocol/page/javascriptDialogEvents.html
diff --git a/LayoutTests/inspector-protocol/page/javascriptDialogEvents.html b/LayoutTests/inspector-protocol/page/javascriptDialogEvents.html
index 6996e2650e8fa1665675089a4b194a0e44d7d957..8d8303aeef61eaf82b322dfa67f0d65afd87e159 100644
--- a/LayoutTests/inspector-protocol/page/javascriptDialogEvents.html
+++ b/LayoutTests/inspector-protocol/page/javascriptDialogEvents.html
@@ -19,11 +19,12 @@ function test()
function onOpening(event)
{
- InspectorTest.log("Opening with message: " + event.params.message);
+ InspectorTest.log("Opening dialog: type=" + event.params.type + "; message=" + event.params.message);
}
- function onClosed()
+
+ function onClosed(event)
{
- InspectorTest.log("Closed");
+ InspectorTest.log("Closed dialog: result=" + event.params.result);
}
InspectorTest.sendCommand("Page.navigate", { "url": "http://nosuchurl" });
« no previous file with comments | « no previous file | LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698