LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt - Issue 1180843006: [DevTools] Add dialog type and return value to Page.javascriptDialog{Opening,Closed}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt

Issue 1180843006: [DevTools] Add dialog type and return value to Page.javascriptDialog{Opening,Closed}. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: frontend Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector-protocol/page/javascriptDialogEvents.html ('k') | Source/core/inspector/InspectorInstrumentation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt

diff --git a/LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt b/LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt

index a74872d4e5ec5488ba4bc89687e0de6b843a4274..46a17a6e6d5429cda9291e51b9dbc7fb067cc8b0 100644

--- a/LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt

+++ b/LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt

@@ -2,12 +2,12 @@ CONFIRM NAVIGATION: beforeunload in javascriptDialogEvents

ALERT: alert

CONFIRM: confirm

PROMPT: prompt, default text:

-Opening with message: beforeunload in javascriptDialogEvents

-Closed

-Opening with message: alert

-Closed

-Opening with message: confirm

-Closed

-Opening with message: prompt

-Closed

+Opening dialog: type=beforeunload; message=beforeunload in javascriptDialogEvents

+Closed dialog: result=true

+Opening dialog: type=alert; message=alert

+Closed dialog: result=true

+Opening dialog: type=confirm; message=confirm

+Closed dialog: result=true

+Opening dialog: type=prompt; message=prompt

+Closed dialog: result=true