Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1180713007: Built-in apply() performance benefits from an uninitialized IC. (Closed)

Created:
5 years, 6 months ago by mvstanton
Modified:
5 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Built-in apply() performance benefits from an uninitialized IC. BUG= Committed: https://crrev.com/2a3b05758721a2f63a7c611ef22e364ead9ed0f3 Cr-Commit-Position: refs/heads/master@{#29175}

Patch Set 1 #

Patch Set 2 : Ports. #

Patch Set 3 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -6 lines) Patch
M src/arm/builtins-arm.cc View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 1 2 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
mvstanton
Hi Toon, I think you reviewed my first crack at this, where I installed the ...
5 years, 6 months ago (2015-06-11 19:58:43 UTC) #3
Toon Verwaest
lgtm
5 years, 6 months ago (2015-06-18 09:44:43 UTC) #4
Toon Verwaest
Lets discuss the context disposal thing later. I'm not sure it's that relevant ...
5 years, 6 months ago (2015-06-18 09:45:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180713007/60001
5 years, 6 months ago (2015-06-22 06:42:38 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 6 months ago (2015-06-22 07:05:20 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 07:05:30 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a3b05758721a2f63a7c611ef22e364ead9ed0f3
Cr-Commit-Position: refs/heads/master@{#29175}

Powered by Google App Engine
This is Rietveld 408576698