Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/mips64/builtins-mips64.cc

Issue 1180713007: Built-in apply() performance benefits from an uninitialized IC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/builtins-mips.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_MIPS64 9 #if V8_TARGET_ARCH_MIPS64
10 10
(...skipping 1388 matching lines...) Expand 10 before | Expand all | Expand 10 after
1399 } 1399 }
1400 1400
1401 1401
1402 static void Generate_PushAppliedArguments(MacroAssembler* masm, 1402 static void Generate_PushAppliedArguments(MacroAssembler* masm,
1403 const int argumentsOffset, 1403 const int argumentsOffset,
1404 const int indexOffset, 1404 const int indexOffset,
1405 const int limitOffset) { 1405 const int limitOffset) {
1406 Label entry, loop; 1406 Label entry, loop;
1407 Register receiver = LoadDescriptor::ReceiverRegister(); 1407 Register receiver = LoadDescriptor::ReceiverRegister();
1408 Register key = LoadDescriptor::NameRegister(); 1408 Register key = LoadDescriptor::NameRegister();
1409 Register slot = LoadDescriptor::SlotRegister();
1410 Register vector = LoadWithVectorDescriptor::VectorRegister();
1409 1411
1410 __ ld(key, MemOperand(fp, indexOffset)); 1412 __ ld(key, MemOperand(fp, indexOffset));
1411 __ Branch(&entry); 1413 __ Branch(&entry);
1412 1414
1413 // Load the current argument from the arguments array. 1415 // Load the current argument from the arguments array.
1414 __ bind(&loop); 1416 __ bind(&loop);
1415 __ ld(receiver, MemOperand(fp, argumentsOffset)); 1417 __ ld(receiver, MemOperand(fp, argumentsOffset));
1416 1418
1417 // Use inline caching to speed up access to arguments. 1419 // Use inline caching to speed up access to arguments.
1418 Handle<Code> ic = masm->isolate()->builtins()->KeyedLoadIC_Megamorphic(); 1420 FeedbackVectorSpec spec(0, Code::KEYED_LOAD_IC);
1421 Handle<TypeFeedbackVector> feedback_vector =
1422 masm->isolate()->factory()->NewTypeFeedbackVector(&spec);
1423 int index = feedback_vector->GetIndex(FeedbackVectorICSlot(0));
1424 __ li(slot, Operand(Smi::FromInt(index)));
1425 __ li(vector, feedback_vector);
1426 Handle<Code> ic = KeyedLoadICStub(masm->isolate()).GetCode();
1419 __ Call(ic, RelocInfo::CODE_TARGET); 1427 __ Call(ic, RelocInfo::CODE_TARGET);
1420 1428
1421 __ push(v0); 1429 __ push(v0);
1422 1430
1423 // Use inline caching to access the arguments. 1431 // Use inline caching to access the arguments.
1424 __ ld(key, MemOperand(fp, indexOffset)); 1432 __ ld(key, MemOperand(fp, indexOffset));
1425 __ Daddu(key, key, Operand(Smi::FromInt(1))); 1433 __ Daddu(key, key, Operand(Smi::FromInt(1)));
1426 __ sd(key, MemOperand(fp, indexOffset)); 1434 __ sd(key, MemOperand(fp, indexOffset));
1427 1435
1428 // Test if the copy loop has finished copying all the elements from the 1436 // Test if the copy loop has finished copying all the elements from the
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
1839 } 1847 }
1840 } 1848 }
1841 1849
1842 1850
1843 #undef __ 1851 #undef __
1844 1852
1845 } // namespace internal 1853 } // namespace internal
1846 } // namespace v8 1854 } // namespace v8
1847 1855
1848 #endif // V8_TARGET_ARCH_MIPS64 1856 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/builtins-mips.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698