Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1180703002: Fixes matrix transformations in sprites (Closed)

Created:
5 years, 6 months ago by viktorl
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds hit tests and transformations between coordinate systems in sprites Sprite nodes use Point instead of Vector2 Updates sprite test app Refactors accounting for pivot points in sprites Adds abstract NodeWithSize class in Sprites. Refactors SpriteNode to Sprite Refactors TransformNode to Node (may need to find another name as it conflicts with Sky's Node). Sprite system now uses and caches transformation matrices. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/476b7fdc67dc470aafff64cae3c45f989f307730

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -444 lines) Patch
M sky/examples/game/lib/game.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/examples/game/lib/game_tests.dart View 4 chunks +73 lines, -9 lines 2 comments Download
M sky/examples/game/lib/game_world.dart View 5 chunks +5 lines, -5 lines 0 comments Download
A + sky/examples/game/lib/node.dart View 11 chunks +88 lines, -75 lines 3 comments Download
A sky/examples/game/lib/node_with_size.dart View 1 chunk +31 lines, -0 lines 1 comment Download
A + sky/examples/game/lib/sprite.dart View 4 chunks +15 lines, -13 lines 0 comments Download
M sky/examples/game/lib/sprite_box.dart View 6 chunks +42 lines, -11 lines 0 comments Download
D sky/examples/game/lib/sprite_node.dart View 1 chunk +0 lines, -71 lines 0 comments Download
M sky/examples/game/lib/sprites.dart View 1 chunk +4 lines, -4 lines 0 comments Download
D sky/examples/game/lib/transform_node.dart View 1 chunk +0 lines, -255 lines 0 comments Download
M sky/examples/game/main.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
viktorl
5 years, 6 months ago (2015-06-11 00:06:01 UTC) #2
abarth-chromium
"Sky's Node" <--- You might want to always import sky with a prefix: import 'dart:sky' ...
5 years, 6 months ago (2015-06-11 00:07:03 UTC) #3
abarth-chromium
https://codereview.chromium.org/1180703002/diff/1/sky/examples/game/lib/game_tests.dart File sky/examples/game/lib/game_tests.dart (right): https://codereview.chromium.org/1180703002/diff/1/sky/examples/game/lib/game_tests.dart#newcode11 sky/examples/game/lib/game_tests.dart:11: Point pointerPos = new Point(event.x, event.y); You might want ...
5 years, 6 months ago (2015-06-11 00:20:20 UTC) #5
abarth-chromium
(Sorry, there were many diffs in this CL and I wasn't sure how detailed a ...
5 years, 6 months ago (2015-06-11 00:20:55 UTC) #6
abarth-chromium
RSLGTM
5 years, 6 months ago (2015-06-11 00:29:15 UTC) #7
abarth-chromium
https://codereview.chromium.org/1180703002/diff/1/sky/examples/game/lib/node.dart File sky/examples/game/lib/node.dart (right): https://codereview.chromium.org/1180703002/diff/1/sky/examples/game/lib/node.dart#newcode231 sky/examples/game/lib/node.dart:231: canvas.concat(list32); canvas.concat(transformMatrix.storage)
5 years, 6 months ago (2015-06-11 00:33:15 UTC) #8
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-11 15:39:08 UTC) #9
viktorl
5 years, 6 months ago (2015-06-11 15:44:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
476b7fdc67dc470aafff64cae3c45f989f307730 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698