Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1180653003: Sync the IDL interfaces in core/frame/ with their many specs (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the IDL interfaces in core/frame/ with their many specs There are no changes to the generated code, other than order, naming and default argument handling in History.go(), which is unobservable. The location-stringify.html test depends on the order of the interface members, so update that to match. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196947

Patch Set 1 #

Patch Set 2 : fix order-dependent test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -33 lines) Patch
M LayoutTests/http/tests/dom/location-stringify.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/Console.idl View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/frame/ConsoleBase.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/History.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/History.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/History.idl View 1 chunk +15 lines, -5 lines 0 comments Download
M Source/core/frame/ImageBitmap.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/frame/Location.idl View 3 chunks +15 lines, -8 lines 0 comments Download
M Source/core/frame/Navigator.idl View 1 chunk +8 lines, -5 lines 0 comments Download
M Source/core/frame/NavigatorCPU.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/NavigatorID.idl View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/frame/NavigatorLanguage.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/NavigatorOnLine.idl View 1 chunk +2 lines, -1 line 0 comments Download
A Source/core/frame/NavigatorStorageUtils.idl View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/frame/ScrollOptions.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/ScrollToOptions.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/StateOptions.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/WindowBase64.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/frame/WindowTimers.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
philipj_slow
PTAL
5 years, 6 months ago (2015-06-11 10:13:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180653003/1
5 years, 6 months ago (2015-06-11 10:13:35 UTC) #4
Jens Widell
LGTM
5 years, 6 months ago (2015-06-11 10:22:30 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/66170)
5 years, 6 months ago (2015-06-11 11:39:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180653003/20001
5 years, 6 months ago (2015-06-11 12:46:48 UTC) #11
philipj_slow
There was an order-dependent test for Location that I updated.
5 years, 6 months ago (2015-06-11 12:46:52 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 14:01:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196947

Powered by Google App Engine
This is Rietveld 408576698