Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: Source/core/frame/History.idl

Issue 1180653003: Sync the IDL interfaces in core/frame/ with their many specs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix order-dependent test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/History.cpp ('k') | Source/core/frame/ImageBitmap.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/History.idl
diff --git a/Source/core/frame/History.idl b/Source/core/frame/History.idl
index 1da581a37fc43c5bb89fb4b4368c22e1f5dcf631..5462033850909d3376e317015f46f12a648cdc13 100644
--- a/Source/core/frame/History.idl
+++ b/Source/core/frame/History.idl
@@ -23,18 +23,28 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+// https://html.spec.whatwg.org/#the-history-interface
+
[
GarbageCollected,
] interface History {
+ // TODO(philipj): length is long in the spec, use that or change the spec:
+ // https://www.w3.org/Bugs/Public/show_bug.cgi?id=28789
readonly attribute unsigned long length;
+ // TODO(philipj): The SerializedScriptValue type should be any.
[CachedAttribute=stateChanged] readonly attribute SerializedScriptValue state;
- [RuntimeEnabled=ScrollRestoration] readonly attribute StateOptions options;
-
+ // TODO(philipj): delta does not have a default value in the spec:
+ // https://www.w3.org/Bugs/Public/show_bug.cgi?id=28790
+ [CallWith=ExecutionContext] void go(optional long delta = 0);
[CallWith=ExecutionContext] void back();
[CallWith=ExecutionContext] void forward();
- [CallWith=ExecutionContext] void go([Default=Undefined] optional long distance);
-
- // FIXME: the title arguments below should simply be 'DOMString title'.
+ // TODO(philipj): The SerializedScriptValue types should be any.
+ // TODO(philipj): The title arguments should simply be 'DOMString title'.
+ // Note: The options arguments are part of the Scroll Restoration API.
[RaisesException] void pushState(SerializedScriptValue data, [TreatUndefinedAs=NullString] DOMString? title, optional DOMString? url = null, optional StateOptions options);
[RaisesException] void replaceState(SerializedScriptValue data, [TreatUndefinedAs=NullString] DOMString? title, optional DOMString? url = null, optional StateOptions options);
+
+ // Experimental Scroll Restoration API
+ // https://www.chromestatus.com/features/5657284784947200
+ [RuntimeEnabled=ScrollRestoration] readonly attribute StateOptions options;
};
« no previous file with comments | « Source/core/frame/History.cpp ('k') | Source/core/frame/ImageBitmap.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698