Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1180613007: Allow larger arrays up to size 8192 for PeriodicWave (Closed)

Created:
5 years, 6 months ago by Raymond Toy
Modified:
5 years, 5 months ago
Reviewers:
hongchan
CC:
blink-reviews, Raymond Toy
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allow larger arrays up to size 8192 for PeriodicWave Larger arrays are allowed, and no errors are thrown if the array is larger than what the implementation would use. Also took this opportunity to slightly optimize the computation of the input signal and the culling of the extra partials. And finally fixed a bug where the 0-th element of the imaginary array was not always being ignored as required. This is tested osc-low-freq.html. BUG=496301 TEST=osc-low-freq.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199389

Patch Set 1 #

Patch Set 2 : Add expected results. #

Patch Set 3 : WIP: More tests #

Patch Set 4 : Fix tests #

Patch Set 5 : #

Total comments: 23

Patch Set 6 : #

Patch Set 7 : Rebase and use Audit.runTasks() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -82 lines) Patch
M LayoutTests/webaudio/dom-exceptions.html View 1 chunk +4 lines, -7 lines 0 comments Download
M LayoutTests/webaudio/dom-exceptions-expected.txt View 1 chunk +3 lines, -4 lines 0 comments Download
A LayoutTests/webaudio/osc-low-freq.html View 1 2 3 4 5 1 chunk +87 lines, -0 lines 0 comments Download
A LayoutTests/webaudio/osc-low-freq-expected.txt View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/webaudio/periodicwave-lengths.html View 1 2 3 4 5 6 1 chunk +263 lines, -0 lines 0 comments Download
A LayoutTests/webaudio/periodicwave-lengths-expected.txt View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M LayoutTests/webaudio/resources/audio-testing.js View 1 2 3 4 5 6 1 chunk +18 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AbstractAudioContext.cpp View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M Source/modules/webaudio/PeriodicWave.h View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/webaudio/PeriodicWave.cpp View 6 chunks +53 lines, -41 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Raymond Toy
PTAL.
5 years, 5 months ago (2015-07-22 18:56:15 UTC) #2
hongchan
https://codereview.chromium.org/1180613007/diff/80001/LayoutTests/webaudio/osc-low-freq.html File LayoutTests/webaudio/osc-low-freq.html (right): https://codereview.chromium.org/1180613007/diff/80001/LayoutTests/webaudio/osc-low-freq.html#newcode19 LayoutTests/webaudio/osc-low-freq.html:19: var highSampleRate = 192000; This is unused. https://codereview.chromium.org/1180613007/diff/80001/LayoutTests/webaudio/osc-low-freq.html#newcode25 LayoutTests/webaudio/osc-low-freq.html:25: ...
5 years, 5 months ago (2015-07-22 21:01:20 UTC) #3
Raymond Toy
https://codereview.chromium.org/1180613007/diff/80001/LayoutTests/webaudio/periodicwave-lengths.html File LayoutTests/webaudio/periodicwave-lengths.html (right): https://codereview.chromium.org/1180613007/diff/80001/LayoutTests/webaudio/periodicwave-lengths.html#newcode87 LayoutTests/webaudio/periodicwave-lengths.html:87: function resultShouldBeZero(sampleRate, bigLength, smallLength) { On 2015/07/22 21:01:19, hoch ...
5 years, 5 months ago (2015-07-22 22:17:48 UTC) #4
hongchan
LGTM with nits. https://codereview.chromium.org/1180613007/diff/80001/LayoutTests/webaudio/periodicwave-lengths.html File LayoutTests/webaudio/periodicwave-lengths.html (right): https://codereview.chromium.org/1180613007/diff/80001/LayoutTests/webaudio/periodicwave-lengths.html#newcode87 LayoutTests/webaudio/periodicwave-lengths.html:87: function resultShouldBeZero(sampleRate, bigLength, smallLength) { On ...
5 years, 5 months ago (2015-07-22 22:30:32 UTC) #5
Raymond Toy
https://codereview.chromium.org/1180613007/diff/80001/LayoutTests/webaudio/osc-low-freq.html File LayoutTests/webaudio/osc-low-freq.html (right): https://codereview.chromium.org/1180613007/diff/80001/LayoutTests/webaudio/osc-low-freq.html#newcode19 LayoutTests/webaudio/osc-low-freq.html:19: var highSampleRate = 192000; On 2015/07/22 21:01:19, hoch wrote: ...
5 years, 5 months ago (2015-07-23 15:33:09 UTC) #6
Raymond Toy
https://codereview.chromium.org/1180613007/diff/80001/Source/modules/webaudio/PeriodicWave.cpp File Source/modules/webaudio/PeriodicWave.cpp (right): https://codereview.chromium.org/1180613007/diff/80001/Source/modules/webaudio/PeriodicWave.cpp#newcode213 Source/modules/webaudio/PeriodicWave.cpp:213: m_bandLimitedTables.append(table.release()); On 2015/07/22 22:30:32, hoch wrote: > I am ...
5 years, 5 months ago (2015-07-23 18:23:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180613007/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1180613007/120001
5 years, 5 months ago (2015-07-23 18:23:43 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 19:34:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199389

Powered by Google App Engine
This is Rietveld 408576698