Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: LayoutTests/webaudio/dom-exceptions.html

Issue 1180613007: Allow larger arrays up to size 8192 for PeriodicWave (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase and use Audit.runTasks() Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/webaudio/dom-exceptions.html
diff --git a/LayoutTests/webaudio/dom-exceptions.html b/LayoutTests/webaudio/dom-exceptions.html
index 0b024f7cd923abfb594f653153a78c5061388c39..4407134feee2e74602f6090e3bcdb772b9dd0317 100644
--- a/LayoutTests/webaudio/dom-exceptions.html
+++ b/LayoutTests/webaudio/dom-exceptions.html
@@ -71,15 +71,12 @@ function runTest() {
// Invalid real/imag arrays: IndexSizeError
shouldThrow("context.createPeriodicWave(null, null)");
shouldThrow("context.createPeriodicWave(new Float32Array(10), null)");
- // Real array is too long.
- shouldThrow("context.createPeriodicWave(new Float32Array(4100), new Float32Array(4100))");
- // Imaginary array is too long.
- shouldThrow("context.createPeriodicWave(new Float32Array(100), new Float32Array(4100))");
+ // Verify that we can use large arrays with no limit. Roughly.
+ shouldNotThrow("context.createPeriodicWave(new Float32Array(4100), new Float32Array(4100))");
+ shouldNotThrow("context.createPeriodicWave(new Float32Array(8192), new Float32Array(8192))");
+ shouldNotThrow("context.createPeriodicWave(new Float32Array(10000), new Float32Array(10000))");
// Real and imaginary arrays must have the same size: IndexSizeError
shouldThrow("context.createPeriodicWave(new Float32Array(10), new Float32Array(7))");
- // Check upper limit is correct.
- shouldNotThrow("context.createPeriodicWave(new Float32Array(2048), new Float32Array(2048))");
- shouldThrow("context.createPeriodicWave(new Float32Array(2049), new Float32Array(2049))");
// Analysers
« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698