Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1180593005: call portable font cleanup only once at app end (Closed)

Created:
5 years, 6 months ago by caryclark
Modified:
5 years, 6 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/sk_tool_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/sk_tool_utils_font.cpp View 2 chunks +1 line, -8 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180593005/1
5 years, 6 months ago (2015-06-15 13:27:08 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-15 13:27:08 UTC) #3
caryclark
5 years, 6 months ago (2015-06-15 13:40:36 UTC) #5
robertphillips
lgtm
5 years, 6 months ago (2015-06-15 13:46:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/f53ce808e9ff942c0bbc3c968e3d9393461c20db
5 years, 6 months ago (2015-06-15 13:48:34 UTC) #7
mtklein
5 years, 6 months ago (2015-06-15 13:57:36 UTC) #8
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1180593005/diff/1/tools/sk_tool_utils_font.cpp
File tools/sk_tool_utils_font.cpp (left):

https://codereview.chromium.org/1180593005/diff/1/tools/sk_tool_utils_font.cp...
tools/sk_tool_utils_font.cpp:72: atexit(release_portable_typefaces);
Ah, we called this for each portable typeface, but release_portable_typefaces
cleans up all of them!

Powered by Google App Engine
This is Rietveld 408576698