call portable font cleanup only once at app end

tools/sk_tool_utils_font.cpp

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "Resources.h"
 #include "SkFontMgr.h"
 #include "SkOSFile.h"
 #include "SkTestScalerContext.h"
 #include "SkThread.h"
 #include "SkUtils.h"
 #include "sk_tool_utils.h"
 
 namespace sk_tool_utils {
 
 #include "test_font_monospace.cpp"
 #include "test_font_sans_serif.cpp"
 #include "test_font_serif.cpp"
 #include "test_font_index.cpp"
 
-static void release_portable_typefaces() {
-    // We'll clean this up in our own tests, but disable for clients.
-    // Chrome seems to have funky multi-process things going on in unit tests that
-    // makes this unsafe to delete when the main process atexit()s.
-    // SkLazyPtr does the same sort of thing.
-#if SK_DEVELOPER
+void release_portable_typefaces() {
     for (int index = 0; index < gTestFontsCount; ++index) {
         SkTestFontData& fontData = gTestFonts[index];
         SkSafeUnref(fontData.fFontCache);
     }
-#endif
 }
 
 SK_DECLARE_STATIC_MUTEX(gTestFontMutex);
 
 SkTypeface* create_font(const char* name, SkTypeface::Style style) {
     SkTestFontData* fontData = NULL;
     const SubFont* sub;
     if (name) {
         for (int index = 0; index < gSubFontsCount; ++index) {
             sub = &gSubFonts[index];
@@ skipping 18 matching lines @@
     SkTestFont* font;
     {
         SkAutoMutexAcquire ac(gTestFontMutex);
         if (fontData->fFontCache) {
             font = SkSafeRef(fontData->fFontCache);
         } else {
             font = SkNEW_ARGS(SkTestFont, (*fontData));
             SkDEBUGCODE(font->fDebugName = sub->fName);
             SkDEBUGCODE(font->fDebugStyle = sub->fStyle);
             fontData->fFontCache = SkSafeRef(font);
-            atexit(release_portable_typefaces);

[mtklein, 2015/06/15 13:57:36]

Ah, we called this for each portable typeface, but release_portable_typefaces
cleans up all of them!

         }
     }
     return SkNEW_ARGS(SkTestTypeface, (font, SkFontStyle(style)));
 }
 
 
 SkTypeface* resource_font(const char* name, SkTypeface::Style style) {
     const char* file = NULL;
     if (name) {
         for (int index = 0; index < gSubFontsCount; ++index) {
@@ skipping 95 matching lines @@
                 break;
             }
         }
        fprintf(out, ";\n");
     }
     fclose(out);
 }
 #endif
 
 }