components/policy/core/common/cloud/device_management_service_unittest.cc - Issue 1180393003: Added characters that look like padlocks to URL unescaping blacklist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/device_management_service_unittest.cc

Issue 1180393003: Added characters that look like padlocks to URL unescaping blacklist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename NON_DISPLAY_CHARS to SPOOFING_AND_CONTROL_CHARS. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/policy/core/common/cloud/device_management_service_unittest.cc

diff --git a/components/policy/core/common/cloud/device_management_service_unittest.cc b/components/policy/core/common/cloud/device_management_service_unittest.cc

index 92b1600ad785af58154a3b796938d233c11b7505..82ca7bb350b283af7598ab4eb78d136b3e21b4a5 100644

--- a/components/policy/core/common/cloud/device_management_service_unittest.cc

+++ b/components/policy/core/common/cloud/device_management_service_unittest.cc

@@ -336,7 +336,7 @@ class QueryParams {

net::UnescapeRule::NORMAL |

net::UnescapeRule::SPACES |

net::UnescapeRule::URL_SPECIAL_CHARS |

- net::UnescapeRule::CONTROL_CHARS |

+ net::UnescapeRule::SPOOFING_AND_CONTROL_CHARS |

net::UnescapeRule::REPLACE_PLUS_WITH_SPACE));

if (unescaped_name == name) {

if (found)

@@ -347,7 +347,7 @@ class QueryParams {

net::UnescapeRule::NORMAL |

net::UnescapeRule::SPACES |

net::UnescapeRule::URL_SPECIAL_CHARS |

- net::UnescapeRule::CONTROL_CHARS |

+ net::UnescapeRule::SPOOFING_AND_CONTROL_CHARS |

net::UnescapeRule::REPLACE_PLUS_WITH_SPACE));

if (unescaped_value != expected_value)

return false;

« no previous file with comments | « chrome/common/instant_types.cc ('k') | content/browser/web_contents/web_drag_source_mac.mm » ('j') | no next file with comments »