chrome/common/instant_types.cc - Issue 1180393003: Added characters that look like padlocks to URL unescaping blacklist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/instant_types.cc

Issue 1180393003: Added characters that look like padlocks to URL unescaping blacklist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename NON_DISPLAY_CHARS to SPOOFING_AND_CONTROL_CHARS. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_util.cc ('k') | components/policy/core/common/cloud/device_management_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/instant_types.cc

diff --git a/chrome/common/instant_types.cc b/chrome/common/instant_types.cc

index b214985963e4969812cbf29b0b01af4fa3bb25e6..c3a2dd236a5cd2242964899edf85d845a47ec699 100644

--- a/chrome/common/instant_types.cc

+++ b/chrome/common/instant_types.cc

@@ -97,9 +97,9 @@ EmbeddedSearchRequestParams::EmbeddedSearchRequestParams(const GURL& url) {

query.len = static_cast<int>(url_params.size());

const net::UnescapeRule::Type unescape_rules =

- net::UnescapeRule::CONTROL_CHARS | net::UnescapeRule::SPACES |

- net::UnescapeRule::URL_SPECIAL_CHARS | net::UnescapeRule::NORMAL |

- net::UnescapeRule::REPLACE_PLUS_WITH_SPACE;

+ net::UnescapeRule::SPOOFING_AND_CONTROL_CHARS |

+ net::UnescapeRule::SPACES | net::UnescapeRule::URL_SPECIAL_CHARS |

+ net::UnescapeRule::NORMAL | net::UnescapeRule::REPLACE_PLUS_WITH_SPACE;

while (url::ExtractQueryKeyValue(url_params.c_str(), &query, &key, &value)) {

if (!key.is_nonempty())