Domain Reliability: Simplify configs and reports

components/domain_reliability/context_manager.cc

Index: components/domain_reliability/context_manager.cc
diff --git a/components/domain_reliability/context_manager.cc b/components/domain_reliability/context_manager.cc
index b06d7fd11e4d48e63bc3945c45dd78824480b6d9..c05e5c8a23e15e926fc137d38e6df9cc93f4e0ac 100644
--- a/components/domain_reliability/context_manager.cc
+++ b/components/domain_reliability/context_manager.cc
@@ -16,13 +16,12 @@ DomainReliabilityContextManager::~DomainReliabilityContextManager() {
 }
 
 void DomainReliabilityContextManager::RouteBeacon(
-    const GURL& url,
-    const DomainReliabilityBeacon& beacon) {
-  DomainReliabilityContext* context = GetContextForHost(url.host());
+    scoped_ptr<DomainReliabilityBeacon> beacon) {
+  DomainReliabilityContext* context = GetContextForHost(beacon->url.host());
   if (!context)
     return;
 
-  context->OnBeacon(url, beacon);
+  context->OnBeacon(beacon.Pass());
 }
 
 void DomainReliabilityContextManager::ClearBeaconsInAllContexts() {
@@ -32,7 +31,15 @@ void DomainReliabilityContextManager::ClearBeaconsInAllContexts() {
 
 DomainReliabilityContext* DomainReliabilityContextManager::AddContextForConfig(
     scoped_ptr<const DomainReliabilityConfig> config) {
-  std::string domain = config->domain;
+  // TODO(ttuttle): Convert this to actual origin.
+
+  // For some reason, initializing |wildcard_prefix| with a ternary operator
+  // makes ASAN mad.

[Randy Smith (Not in Mondays), 2015/10/29 22:36:11]

You'll hate me for this, but that's what reviewers are for.  Can you at least
reduce this to a bug filed against ASAN before landing?

[Deprecated (see juliatuttle), 2015/11/02 23:19:30]

Do you know how to run standalone binaries against ASAN? I want to make a test
case but all I'm finding is instructions on building all of Chrome with it.

[Randy Smith (Not in Mondays), 2015/11/03 21:48:12]

Sorry, I don't.  

I thought we decided you'd remove the comment and work this separately from this
CL?

[Randy Smith (Not in Mondays), 2015/11/09 21:23:24]

Ping?

+  std::string wildcard_prefix = "";
+  if (config->include_subdomains)
+    wildcard_prefix = "*.";

[Randy Smith (Not in Mondays), 2015/10/29 22:36:11]

Why doesn't this result in only seeing subdomains and not the main domain?

[Deprecated (see juliatuttle), 2015/11/02 23:19:30]

Because GetContextForHost("foo.bar") looks for "foo.bar", then "*.foo.bar", then
"*.bar".

[Randy Smith (Not in Mondays), 2015/11/03 21:48:12]

Oh, and the only thing that wildcard_prefix is used for is creating domain to
index contexts_.  Ok, nm.

+
+  std::string domain = wildcard_prefix + config->origin.host();
   scoped_ptr<DomainReliabilityContext> context =
       context_factory_->CreateContextForConfig(config.Pass());
   DomainReliabilityContext** entry = &contexts_[domain];