Domain Reliability: Simplify configs and reports

components/domain_reliability/context_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/context_manager.h"
 
 namespace domain_reliability {
 
 DomainReliabilityContextManager::DomainReliabilityContextManager(
     DomainReliabilityContext::Factory* context_factory)
     : context_factory_(context_factory) {
 }
 
 DomainReliabilityContextManager::~DomainReliabilityContextManager() {
   RemoveAllContexts();
 }
 
 void DomainReliabilityContextManager::RouteBeacon(
-    const GURL& url,
-    const DomainReliabilityBeacon& beacon) {
-  DomainReliabilityContext* context = GetContextForHost(url.host());
+    scoped_ptr<DomainReliabilityBeacon> beacon) {
+  DomainReliabilityContext* context = GetContextForHost(beacon->url.host());
   if (!context)
     return;
 
-  context->OnBeacon(url, beacon);
+  context->OnBeacon(beacon.Pass());
 }
 
 void DomainReliabilityContextManager::ClearBeaconsInAllContexts() {
   for (auto& context_entry : contexts_)
     context_entry.second->ClearBeacons();
 }
 
 DomainReliabilityContext* DomainReliabilityContextManager::AddContextForConfig(
     scoped_ptr<const DomainReliabilityConfig> config) {
-  std::string domain = config->domain;
+  // TODO(ttuttle): Convert this to actual origin.
+
+  // For some reason, initializing |wildcard_prefix| with a ternary operator
+  // makes ASAN mad.

[Randy Smith (Not in Mondays), 2015/10/29 22:36:11]

You'll hate me for this, but that's what reviewers are for.  Can you at least
reduce this to a bug filed against ASAN before landing?

[Deprecated (see juliatuttle), 2015/11/02 23:19:30]

Do you know how to run standalone binaries against ASAN? I want to make a test
case but all I'm finding is instructions on building all of Chrome with it.

[Randy Smith (Not in Mondays), 2015/11/03 21:48:12]

Sorry, I don't.  

I thought we decided you'd remove the comment and work this separately from this
CL?

[Randy Smith (Not in Mondays), 2015/11/09 21:23:24]

Ping?

+  std::string wildcard_prefix = "";
+  if (config->include_subdomains)
+    wildcard_prefix = "*.";

[Randy Smith (Not in Mondays), 2015/10/29 22:36:11]

Why doesn't this result in only seeing subdomains and not the main domain?

[Deprecated (see juliatuttle), 2015/11/02 23:19:30]

Because GetContextForHost("foo.bar") looks for "foo.bar", then "*.foo.bar", then
"*.bar".

[Randy Smith (Not in Mondays), 2015/11/03 21:48:12]

Oh, and the only thing that wildcard_prefix is used for is creating domain to
index contexts_.  Ok, nm.

+
+  std::string domain = wildcard_prefix + config->origin.host();
   scoped_ptr<DomainReliabilityContext> context =
       context_factory_->CreateContextForConfig(config.Pass());
   DomainReliabilityContext** entry = &contexts_[domain];
   if (*entry)
     delete *entry;
   *entry = context.release();
   return *entry;
 }
 
 void DomainReliabilityContextManager::RemoveAllContexts() {
@@ skipping 30 matching lines @@
 
   std::string parent_with_asterisk = "*." + host.substr(dot_pos + 1);
   context_it = contexts_.find(parent_with_asterisk);
   if (context_it != contexts_.end())
     return context_it->second;
 
   return nullptr;
 }
 
 }  // namespace domain_reliability