Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 1180223004: Check user gesture before firing an intent in WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed failing test, added another Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 1c4d632809046c9076e1376f1f5da88316c23bb1..ca277be7d280e5213f843835094a09ae530c0794 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -59,6 +59,8 @@ public:
void OnShouldOverrideUrlLoading(int routing_id,
const base::string16& url,
+ bool has_user_gesture,
+ bool is_redirect,
bool* ignore_navigation);
void OnSubFrameCreated(int parent_render_frame_id, int child_render_frame_id);
@@ -99,13 +101,16 @@ bool AwContentsMessageFilter::OnMessageReceived(const IPC::Message& message) {
void AwContentsMessageFilter::OnShouldOverrideUrlLoading(
int render_frame_id,
const base::string16& url,
+ bool has_user_gesture,
+ bool is_redirect,
bool* ignore_navigation) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
*ignore_navigation = false;
AwContentsClientBridgeBase* client =
AwContentsClientBridgeBase::FromID(process_id_, render_frame_id);
if (client) {
- *ignore_navigation = client->ShouldOverrideUrlLoading(url);
+ *ignore_navigation =
+ client->ShouldOverrideUrlLoading(url, has_user_gesture, is_redirect);
} else {
LOG(WARNING) << "Failed to find the associated render view host for url: "
<< url;
« no previous file with comments | « no previous file | android_webview/browser/aw_contents_client_bridge_base.h » ('j') | android_webview/common/render_view_messages.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698