Source/core/paint/FrameSetPainter.cpp - Issue 1180143003: Don't paint self-painting frameset frames in the layout tree paint recursion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/FrameSetPainter.cpp

Issue 1180143003: Don't paint self-painting frameset frames in the layout tree paint recursion. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/paint/frames/resources/subframe.html ('K') | « LayoutTests/platform/linux/paint/frames/frameset-with-stacking-contexts-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/FrameSetPainter.cpp

diff --git a/Source/core/paint/FrameSetPainter.cpp b/Source/core/paint/FrameSetPainter.cpp

index 48161d2f58b9ef17624cb951b96390fc94052296..f026f3fce0ab7f5dd86a0389916f394540ecb01e 100644

--- a/Source/core/paint/FrameSetPainter.cpp

+++ b/Source/core/paint/FrameSetPainter.cpp

@@ -115,6 +115,8 @@ void FrameSetPainter::paintChildren(const PaintInfo& paintInfo, const LayoutPoin

size_t cols = m_layoutFrameSet.columns().m_sizes.size();

for (size_t r = 0; r < rows; r++) {

for (size_t c = 0; c < cols; c++) {

+ if (child->isLayoutBoxModelObject() && toLayoutBoxModelObject(child)->hasSelfPaintingLayer())

wkorman 2015/06/12 19:14:48 Worth adding a comment on why we do this?

chrishtr 2015/06/12 19:57:28 Done.

+ continue;

child->paint(paintInfo, adjustedPaintOffset);

child = child->nextSibling();

if (!child)