Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Issue 1179763004: X87: enable the X87 turbofan support. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: enable the X87 turbofan support. This patch includes the following changes. 1, Enable the turbofan backend support for X87 platform. It depends on previous CL: 3fdfebd26. 2, Enable the test cases which are disabled because turbofan for X87 was not enabled. BUG=v8:4135 LOG=N Committed: https://crrev.com/ebb0f9e52e32832de470cbe8a068e4218e584aae Cr-Commit-Position: refs/heads/master@{#29049}

Patch Set 1 : #

Patch Set 2 : rebase and enable test cases #

Patch Set 3 : Add OWNERS file #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1087 lines, -571 lines) Patch
M src/compiler/instruction-codes.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/compiler/x87/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + src/compiler/x87/code-generator-x87.cc View 1 2 3 30 chunks +672 lines, -343 lines 0 comments Download
A src/compiler/x87/instruction-codes-x87.h View 1 2 3 1 chunk +121 lines, -0 lines 0 comments Download
A + src/compiler/x87/instruction-selector-x87.cc View 1 2 3 39 chunks +196 lines, -205 lines 0 comments Download
A + src/compiler/x87/linkage-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/assembler-x87.h View 1 2 3 3 chunks +17 lines, -0 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 2 3 4 chunks +53 lines, -0 lines 0 comments Download
M src/x87/disasm-x87.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +1 line, -6 lines 0 comments Download
M test/message/message.status View 1 1 chunk +0 lines, -8 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -6 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
chunyang.dai
PTAL.
5 years, 6 months ago (2015-06-15 04:45:47 UTC) #5
Weiliang
please run "git cl format" before uploading patch. https://codereview.chromium.org/1179763004/diff/100001/src/compiler/x87/instruction-selector-x87.cc File src/compiler/x87/instruction-selector-x87.cc (right): https://codereview.chromium.org/1179763004/diff/100001/src/compiler/x87/instruction-selector-x87.cc#newcode1293 src/compiler/x87/instruction-selector-x87.cc:1293: /* ...
5 years, 6 months ago (2015-06-15 06:14:30 UTC) #6
Weiliang
LGTM, but CL still needs LGTM from V8 team. @danno, @Titzer Thanks -Weiliang
5 years, 6 months ago (2015-06-15 06:26:04 UTC) #7
chunyang.dai
Hello, Danno & Titizer. PTAL. thanks.
5 years, 6 months ago (2015-06-15 06:33:46 UTC) #9
danno
With Ben and I both traveling, it's probably better that Benedikt or Michi review this.
5 years, 6 months ago (2015-06-16 10:54:30 UTC) #11
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-16 10:58:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179763004/120001
5 years, 6 months ago (2015-06-16 10:58:41 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:120001)
5 years, 6 months ago (2015-06-16 11:23:11 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 11:23:31 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ebb0f9e52e32832de470cbe8a068e4218e584aae
Cr-Commit-Position: refs/heads/master@{#29049}

Powered by Google App Engine
This is Rietveld 408576698