Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1179733004: [arm64][turbofan]: Handle any immediate shift. (Closed)

Created:
5 years, 6 months ago by jbramley
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev, m.m.capewell
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64][turbofan]: Handle any immediate shift. With this patch, we can generate simple immediate-shift instructions for immediates outside the range "0 <= imm < width". Several related instruction selectors have also been updated accordingly. Example of generated code: ---- Before --- ---- After ---- movz w0, #33 lsr w0, w1, #1 lsr w0, w1, w0 BUG= Committed: https://crrev.com/36d771bbfa4af5efcc1c1dcf5b234445cb7ee722 Cr-Commit-Position: refs/heads/master@{#28943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -101 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 8 chunks +84 lines, -71 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 12 chunks +42 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbramley
This is relevant to the discussion in issue 1179503003. As I see it, we have ...
5 years, 6 months ago (2015-06-11 13:09:42 UTC) #2
Benedikt Meurer
Yeah, I see your point. I guess the argumentation makes sense, so let's go for ...
5 years, 6 months ago (2015-06-11 13:23:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179733004/1
5 years, 6 months ago (2015-06-11 13:26:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 13:50:56 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/36d771bbfa4af5efcc1c1dcf5b234445cb7ee722 Cr-Commit-Position: refs/heads/master@{#28943}
5 years, 6 months ago (2015-06-11 13:51:13 UTC) #7
jbramley
5 years, 6 months ago (2015-06-11 14:46:15 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1176393002/ by jacob.bramley@arm.com.

The reason for reverting is: Breaks
InstructionSelectorTest.Word64ShrWithWord64AndWithImmediate on debug builds (but
not optdebug builds). I'll investigate..

Powered by Google App Engine
This is Rietveld 408576698