Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1179643005: first step for #168, adds dart:js impl to the build (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
vsm, Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

first step for #168, adds dart:js impl to the build the code most likely does not work yet. But this gets it in so we can iterate more easily, from a clean baseline. R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/caa101b9ba54408b894b4efe42564f405dc52868

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1737 lines, -605 lines) Patch
A lib/runtime/dart/js.js View 1 chunk +452 lines, -0 lines 0 comments Download
M lib/src/analysis_context.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tool/build_sdk.sh View 1 1 chunk +4 lines, -2 lines 0 comments Download
A tool/input_sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +593 lines, -0 lines 0 comments Download
M tool/sdk_expected_errors.txt View 3 chunks +685 lines, -601 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
https://codereview.chromium.org/1179643005/diff/20001/tool/build_sdk.sh File tool/build_sdk.sh (right): https://codereview.chromium.org/1179643005/diff/20001/tool/build_sdk.sh#newcode17 tool/build_sdk.sh:17: --dart-sdk tool/generated_sdk -o lib/runtime/ dart:js \ JS includes core, ...
5 years, 6 months ago (2015-06-12 21:03:06 UTC) #3
Jacob
lgtm https://codereview.chromium.org/1179643005/diff/20001/tool/build_sdk.sh File tool/build_sdk.sh (right): https://codereview.chromium.org/1179643005/diff/20001/tool/build_sdk.sh#newcode17 tool/build_sdk.sh:17: --dart-sdk tool/generated_sdk -o lib/runtime/ dart:js \ On 2015/06/12 ...
5 years, 6 months ago (2015-06-12 21:07:24 UTC) #4
Jennifer Messerly
https://codereview.chromium.org/1179643005/diff/20001/tool/build_sdk.sh File tool/build_sdk.sh (right): https://codereview.chromium.org/1179643005/diff/20001/tool/build_sdk.sh#newcode17 tool/build_sdk.sh:17: --dart-sdk tool/generated_sdk -o lib/runtime/ dart:js \ On 2015/06/12 21:07:23, ...
5 years, 6 months ago (2015-06-12 22:02:36 UTC) #5
Jennifer Messerly
5 years, 6 months ago (2015-06-12 22:17:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
caa101b9ba54408b894b4efe42564f405dc52868 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698