tool/build_sdk.sh - Issue 1179643005: first step for #168, adds dart:js impl to the build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/build_sdk.sh

Issue 1179643005: first step for #168, adds dart:js impl to the build (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/build_sdk.sh

diff --git a/tool/build_sdk.sh b/tool/build_sdk.sh

index 9d5078ee981c6ce84edf316725092a1c650da1e5..b473350bc957b8b5110a658bf1448042ea05b59e 100755

--- a/tool/build_sdk.sh

+++ b/tool/build_sdk.sh

@@ -12,9 +12,11 @@ if [[ -d lib/runtime/dart ]] ; then

rm -r lib/runtime/dart

-# TODO(jmesserly): for now we're suppressing errors in SDK compilation

+# TODO(jmesserly): this builds dart:js, which pulls in dart:core and many others

+# transitively. Ideally we could pass them explicitly, though:

+# https://github.com/dart-lang/dev_compiler/issues/219

dart -c bin/devc.dart --no-source-maps --sdk-check --force-compile -l warning \

- --dart-sdk tool/generated_sdk -o lib/runtime/ dart:core \

+ --dart-sdk tool/generated_sdk -o lib/runtime/ dart:js \

> tool/generated_sdk/sdk_errors.txt || true

if [[ ! -f lib/runtime/dart/core.js ]] ; then

« no previous file with comments | « lib/src/analysis_context.dart ('k') | tool/input_sdk/lib/js/dart2js/js_dart2js.dart » ('j') | no next file with comments »