Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1179563004: Renames the assembler* files. (Closed)

Created:
5 years, 6 months ago by John
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Refactors method names in IceAssembler #

Patch Set 3 : Reintegrates the changes to IceAssemblerX8632.cpp. #

Patch Set 4 : Restores assembler_ia32.cpp #

Patch Set 5 : git mv src/assembler_ia32.cpp src/IceAssemblerX8632.cpp #

Patch Set 6 : Reintegrates the changes to IceAssemblerX8632.cpp. #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : Changes the top comment for IceAssemblerX8632.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2770 lines, -4128 lines) Patch
M Makefile.standalone View 1 chunk +2 lines, -2 lines 0 comments Download
A + src/IceAssembler.h View 1 10 chunks +60 lines, -59 lines 0 comments Download
A + src/IceAssembler.cpp View 1 4 chunks +41 lines, -41 lines 0 comments Download
A + src/IceAssemblerARM32.h View 1 4 chunks +6 lines, -7 lines 0 comments Download
A + src/IceAssemblerX8632.h View 1 5 chunks +40 lines, -41 lines 0 comments Download
A src/IceAssemblerX8632.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +2609 lines, -0 lines 0 comments Download
M src/IceCfg.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceCfg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceCfgNode.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceELFObjectWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceInstX8632.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceInstX8632.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 chunk +1 line, -1 line 0 comments Download
D src/assembler.h View 1 chunk +0 lines, -233 lines 0 comments Download
D src/assembler.cpp View 1 chunk +0 lines, -154 lines 0 comments Download
D src/assembler_arm32.h View 1 chunk +0 lines, -77 lines 0 comments Download
D src/assembler_ia32.h View 1 chunk +0 lines, -893 lines 0 comments Download
D src/assembler_ia32.cpp View 4 7 1 chunk +0 lines, -2609 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
John
5 years, 6 months ago (2015-06-10 22:28:47 UTC) #2
jvoung (off chromium)
LGTM thanks
5 years, 6 months ago (2015-06-10 23:34:17 UTC) #3
John
5 years, 6 months ago (2015-06-10 23:35:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #10 (id:170001) manually as
aff4ccf9a77b664127f2fd5bc0b98243008be067 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698