chrome/chrome.gyp - Issue 1179393004: Fix some build symbol configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome.gyp

Issue 1179393004: Fix some build symbol configuration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome.gyp

diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp

index 81b256d9d2476536b9d338cde97c402a0ac4db52..22fa351148d2a48b25b3d9accc704009e605c567 100644

--- a/chrome/chrome.gyp

+++ b/chrome/chrome.gyp

@@ -349,6 +349,7 @@

['OS=="linux"',

{ 'targets': [

{

+ # GN version: //chrome:linux_symbols

'target_name': 'linux_symbols',

'type': 'none',

'conditions': [

@@ -357,14 +358,15 @@

{

'action_name': 'dump_symbols',

'inputs': [

- '<(DEPTH)/build/linux/dump_app_syms',

+ '<(DEPTH)/build/linux/dump_app_syms.py',

'<(PRODUCT_DIR)/dump_syms',

'<(PRODUCT_DIR)/chrome',

'outputs': [

'<(PRODUCT_DIR)/chrome.breakpad.<(target_arch)',

- 'action': ['<(DEPTH)/build/linux/dump_app_syms',

+ 'action': ['python',

+ '<(DEPTH)/build/linux/dump_app_syms.py',

'<(PRODUCT_DIR)/dump_syms',

'<(linux_strip_binary)',

'<(PRODUCT_DIR)/chrome',

« no previous file with comments | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »