Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: chrome/BUILD.gn

Issue 1179393004: Fix some build symbol configuration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/linux/dump_app_syms.py ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index ba6b789a4550f948f40cd24e161c15600e17651b..0197f35c004768b793e6b3999701972f6d4e66d4 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -808,4 +808,40 @@ if (is_linux) {
"-e s/@@CONFDIR@@/$confdir/",
]
}
+
+ action("linux_symbols") {
+ script = "//build/linux/dump_app_syms"
+
+ dump_syms_label = "//breakpad:dump_syms($host_toolchain)"
+ dump_syms_binary =
+ get_label_info(dump_syms_label, "root_out_dir") + "/" + "dump_syms"
+
+ chrome_binary = "$root_out_dir/chrome"
+ if (current_cpu == "x86") {
+ # Use "ia32" instead of "x86" for GYP compat.
+ symbol_file = "$root_out_dir/chrome.breakpad.ia32"
+ } else {
+ symbol_file = "$root_out_dir/chrome.breakpad.$current_cpu"
+ }
+
+ inputs = [
+ chrome_binary,
+ dump_syms_binary,
+ ]
+ outputs = [
+ symbol_file,
+ ]
+
+ args = [
+ rebase_path(dump_syms_binary, root_build_dir),
+ "0", # TODO(GYP) This is linux_strip_binary if it is needed.
+ rebase_path(chrome_binary, root_build_dir),
+ rebase_path(symbol_file, root_build_dir),
+ ]
+
+ deps = [
+ ":chrome",
+ dump_syms_label,
+ ]
+ }
}
« no previous file with comments | « build/linux/dump_app_syms.py ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698