Video Capture: extract storage info from pixel format in VideoCaptureFormat.

media/capture/screen_capture_device_core.cc

Index: media/capture/screen_capture_device_core.cc
diff --git a/media/capture/screen_capture_device_core.cc b/media/capture/screen_capture_device_core.cc
index a8993e7ef897b64691500c27b04eedcfbf7d2293..29bbf2745757b6051f8c970a086f03d08559474b 100644
--- a/media/capture/screen_capture_device_core.cc
+++ b/media/capture/screen_capture_device_core.cc
@@ -42,7 +42,7 @@ void ScreenCaptureDeviceCore::AllocateAndStart(
   }
 
   if (params.requested_format.pixel_format != PIXEL_FORMAT_I420 &&
-      params.requested_format.pixel_format != PIXEL_FORMAT_TEXTURE) {
+      params.requested_format.pixel_storage != PIXEL_STORAGE_TEXTURE) {

[miu, 2015/06/23 22:58:15]

I think the logical-AND should be a logical-OR now, right?

[mcasas, 2015/06/23 23:24:43]

Done.

[miu, 2015/06/23 23:35:55]

Oh wait.  I might have misled you here.  I think there are only two supported
format+storage combos: I420+STORAGE_CPU and ARGB+STORAGE_TEXTURE.  The logic
should probably be:

  if (!(params.requested_format.pixel_format == PIXEL_FORMAT_I420 &&
        params.requested_format.pixel_storage == PIXEL_STORAGE_CPU) &&
      !(params.requested_format.pixel_format == PIXEL_FORMAT_ARGB &&
        params.requested_format.pixel_storage == PIXEL_STORAGE_TEXTURE)) {
    ...do unsupported error...
    return;
  }

[mcasas, 2015/06/24 00:16:39]

Done.

     std::string error_msg = base::StringPrintf(
         "unsupported format: %d", params.requested_format.pixel_format);

[miu, 2015/06/23 22:58:15]

Please update error message to include storage texture, as well.

[mcasas, 2015/06/23 23:24:43]

Done.

     DVLOG(1) << error_msg;